-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(firebaseai): add bidi transcript #17700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/gemini summarize |
This pull request introduces bidirectional transcription capabilities for Firebase AI. Key changes include:
This feature enhances the live generation experience by providing real-time text representations of both user input and model output audio. |
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for bidirectional transcription in Firebase AI. The changes are well-structured, introducing new configurations and handling transcription messages. I've identified a few areas for improvement, including an unused variable, opportunities to reduce code duplication, and a suggestion to maintain immutability in a data class. My detailed comments and code suggestions aim to enhance code quality and maintainability.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?